When running on CLI (for example with Drush), $_SERVER['SERVER_SOFTWARE'] is not set.

When, for example, a standard system mail is sent during the command execution, the mail() function in system.mail.inc produces the following deprecation warning:

strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated system.mail.inc:72

This is comparable to this issue. The attached patch works in a similar way to get rid of the warning.

CommentFileSizeAuthor
system.mail_.inc_.patch997 byteschase.

Comments

Chase. created an issue. See original summary.

chase.’s picture

chase. commented
Assigned: chase. » Unassigned
poker10’s picture

poker10 commented
Status: Active » Needs review
Parent issue: » #3314489: strpos(): Passing null to parameter in PhpMail
Related issues: +#967046: Notice: Undefined index: SERVER_SOFTWARE in system_requirements(), +#1192102: make cron.php compatible to php-cli (or change documentation)

Thanks for reporting this. Adding some related issues.

poker10’s picture

poker10 commented

I think this fix looks good, thanks! The similar change is needed for D10 (see the parent issue), but there is a Request class used and it returns a default value in case the specific $_SERVER key is not defined. So a fix will be a bit different there.

poker10’s picture

poker10 commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Pending Drupal 7 commit
Parent issue: #3314489: strpos(): Passing null to parameter in PhpMail » #3328187: PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in docroot/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php on line 112
Related issues: +#2983438: Truncated MailFrom address - Incorrect Windows detection, +#3314489: strpos(): Passing null to parameter in PhpMail, +#3319062: [D7] PhpMail : broken mail headers in PHP 8.0+ because of LF characters

Adding a tag for a final review.

Just a note, we should keep an eye on these two issues:

#2983438: Truncated MailFrom address - Incorrect Windows detection
#3328187: PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in docroot/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php on line 112

But I suppose that for D7 it would be better to fix this deprecation message as the patch proposes (we have already done it in #2356055: Notice in includes/mail.inc define) and then see, what to do with the check in overall in the separate existing issue referenced above.

The windows check is probably also related to this issue: #3319062: [D7] PhpMail : broken mail headers in PHP 8.0+ because of LF characters

  • mcdruid committed c8686051 on 7.x 
    Issue #3348669 by Chase., poker10: system.mail.inc: strpos(): Passing...
mcdruid’s picture

mcdruid commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.