The define at the top of mail.inc causes a notice if $_SERVER['SERVER_SOFTWARE'] is not set. This appears minor, but causes issues with us when using resque and php-resque to execute jobs. Patch to follow.

CommentFileSizeAuthor
#1 drupal-mail_notice-2356055-1.patch578 bytesbdlangton

Comments

bdlangton’s picture

bdlangton commented
StatusFileSize
new drupal-mail_notice-2356055-1.patch578 bytes
les lim’s picture

les lim
he/they
Primary language English
commented
Status: Active » Reviewed & tested by the community

Yeah, that's a sensible change. Replicated the notice and confirmed that the patch in #1 fixes it.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Still, testbot needs a crack at it.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

RTBC. This is not an issue in D8, since Request object methods are being used there.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed d7ea3ba on 7.x 
    Issue #2356055 by bdlangton: Fixed Notice in includes/mail.inc define.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.