Problem/Motivation

When you enable the module, the method hook_help is not implemented.

Steps to reproduce

Download and activate the module and visit its help page.

Proposed resolution

Implement the hook_help and describe the module's functionality and usage.

CommentFileSizeAuthor
#8 3348628-HelpPage.png191.18 KBclarkssquared
#8 3348628-after.png76.48 KBclarkssquared
#8 3348628-before.png87.02 KBclarkssquared
#4 after-patch-HelpClicked.png437.81 KBclarkssquared
#4 after-patch.png140.39 KBclarkssquared
#4 before-patch.png67.16 KBclarkssquared

Issue fork activitypub-3348628

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sahana _N created an issue. See original summary.

Sahana _N opened merge request !22

sahana _n’s picture

sahana _n commented
Status: Active » Needs review

Please review the MR

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new before-patch.png67.16 KB
new after-patch.png140.39 KB
new after-patch-HelpClicked.png437.81 KB

Hi Sahana _N,

I applied your MR in my local with Drupal 9.5.4, it worked for me the module has now the hook_help() method but when I visit the help page an error TypeError: activitypub_help(): Argument #2 ($route_match) must be of type RouteMatchInterface, Drupal\Core\Routing\CurrentRouteMatch given in activitypub_help() (line 22 of modules/contrib/activitypub/activitypub.module). appears.

Please look at the screenshots attached for your reference.

For your review.
Thank you.

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: Unassigned » himanshu_jhaloya

I will work on this

himanshu_jhaloya opened merge request !23

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: himanshu_jhaloya » Unassigned
Status: Needs work » Needs review
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3348628-before.png87.02 KB
new 3348628-after.png76.48 KB
new 3348628-HelpPage.png191.18 KB

Hi Sahana _N,

I applied MR !23 in my local with Drupal 9.5.7 to the "ActivityPub" module against "
1.0.x-dev" version and confirmed that the hook_help() method is implemented and the help page is now accessible.

Please look at the screenshots attached for your reference.

For your review.
Thank you.

nader.mouldi made their first commit to this issue’s fork.

nader.mouldi opened merge request !24

nader.mouldi opened merge request !25

swentel closed merge request !22

swentel closed merge request !23

swentel made their first commit to this issue’s fork.

swentel’s picture

swentel commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

swentel closed merge request !24

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.