The highlightjs Input Filter module adds an input filter which allows users to configure the text editor to highlight syntax using the highlight.js library.
The CKEditor CodeSnippet module provides this ability. However, that module is not being updated to Drupal 10, because most of the functionality is included with CKEditor 5. So, this module provides syntax highlighting. Furthermore, this module works without a dedicated code snippet button.
The Prism module is similar, but that uses the PrismJS library instead. The highlight.js library has the ability to automatically detect the code language used within code tags if one is not specified.
There is a D7 highlightjs module that I considered updating. However, that module maintainer plans to rewrite that module to provide the syntax highlighting using a specific field, not an input filter.
Comments
Comment #2
vishal.kadamThank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
Comment #3
vishal.kadamComment #4
vishal.kadam1. Fix phpcs issue.
2. FILE: highlightjs_input_filter.info.yml
package: customModules should avoid using this value for the package.
3. README.md file is missing a few required sections.
Please take a moment to make your README.md follow the guidelines.
Comment #5
vishal.kadamUsually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.
This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.
Have you made any other contributions that we could instead review?
Comment #6
avpadernoTo make the previous comment clearer: This application can continue only with another project.
Comment #7
avpadernoComment #8
vinaymahale commentedComment #9
avpadernoComment #10
nmangold commentedI have added more features to this module, including a module settings form, route, menu item. Also, the module is dynamically loading assets to optimize page load times.
Is this enough changes to consider? If not, please give me an example of the minimum amount of code to consider being approved.
Comment #11
vinaymahale commentedComment #12
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the reviewers.
Comment #13
avpaderno