Hi and welcome to the fortnightly meeting of the Bug Smash Needs Review queue initiative
This meeting:
➤ Is for contributors who are interested in helping reduce the number of open bugs against Drupal 9 and Drupal 10 core.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Transcript will be exported and posted to a core issue for this meeting. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

:zero: whos here?

Indrajith KB Indrajith From India. I am new to this channel.
borisson_ :wave:
nod_ :wave:

:zero:.:five: anyone have a old issue they were excited to finally see land?

:one: anyone have a specific ticket they wish to discuss. Or I’m going to pull from the end

:two: anyone on a windows that could test https://www.drupal.org/project/drupal/issues/2911377

smustgrave I’m on a macbook so don’t think I can test.
catch Not sure about
@neclimdul
's comment and str_replace() here, to me that looks OK since we know what's in the string.
I spammed #contribute https://drupal.slack.com/archives/C1BMUQ9U6/p1678890300148339
smustgrave Thanks
catch If we can't find anyone to test it,I would probably commit without manual testing of the unit tests. And then next time someone runs those unit tests on windows it'll either work or we'll get another issue.
Spokje Successfully tested on Windows 11, left comment and RTBCed.
smustgrave Thanks
smustgrave I owe you about 3 gazillion favours, so now it's 3 gazillion minus one

:three: https://www.drupal.org/project/drupal/issues/3331548

smustgrave @longwave suggestion for testing this for you?.
longwave i guess the steps are what happened in #8 to #10 in https://www.drupal.org/project/ckeditor5/issues/3201820#comment-14039397
longwave needs explicitly testing on Safari
longwave ie. that a ckeditor5-enabled textarea in the off-canvas tray still works and has the blinking cursor in Safari after applying the patch
smustgrave Applied the patch. Using layout builder to create a block. The cursor is blinking in the ckeditor5

:four: https://www.drupal.org/project/drupal/issues/1461042

smustgrave @Kim Pepper could you take a look at this one please?
borisson_ rtbc
borisson_ I wasn't sure if this should live in user module or in file module (as noted on the issue as well)
smustgrave Thanks! @borisson_
borisson_ but I think it should live in file, because file can be disabled and we don't want to have a if module_enabled('file') in user module I think

:five: https://www.drupal.org/project/drupal/issues/3084554

smustgrave @ckrina @lauriii @bnjmnm @saschaeggi could one of you take a look please? Tagged for subsystem review

:six: Going to call it a few minutes early. Thanks!

Comments

smustgrave created an issue. See original summary.

smustgrave credited borisson_.

smustgrave credited catch.

smustgrave credited longwave.

smustgrave credited Spokje.

smustgrave’s picture

smustgrave commented
smustgrave’s picture

smustgrave commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.