Problem/Motivation

There is no config form for editing the Max Depth setting. Currently, you have to edit the YAML manually.

Proposed resolution

Add a config form.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork bigmenu-3348166

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

solideogloria created an issue. See original summary.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I can work on it.

elber opened merge request !3

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Active » Needs review

Hi I added a config form please revise.

acbramley’s picture

acbramley commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Comments added to the MR, we also need a test because currently it is broken.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi I fixed the errors please revise.

solideogloria’s picture

solideogloria commented
Status: Needs review » Needs work

I would suggest using a different form ID than big_menu_form_id_settings. It seems wrong to put "form_id" in the ID. How about bigmenu_settings (the module name doesn't have a space in it).

Similarly, in the routing file, it should be bigmenu.settings, not big_menu.settings (the module name doesn't have a space in it).

Then, we should add configure: bigmenu.settings to the info file.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review

Hi I did the requested changes please revise.

solideogloria’s picture

solideogloria commented

The code looks good to me, but I can't get the patch to apply when I tried using Composer. I don't know why.

Also we should fix the Composer errors that show for the tests.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

you can try to clone the module

acbramley’s picture

acbramley commented
Status: Needs review » Needs work

Still needs tests.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

is there something I need to do?

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review

Hi I install the module using composer after that ran the issue fork's commands and checkout to respective branch.

I was able to revised the changes using composer to install the module.

solideogloria’s picture

solideogloria commented
Status: Needs review » Needs work

per #11, this has to stay Needs Work until tests are added.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will work on it.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi I added a test to this new feature please revise 

Testing Drupal\Tests\bigmenu\Functional\BigMenuSettingsFormTest
.                                                                   1 / 1 (100%)

Time: 00:13.657, Memory: 10.00 MB

OK (1 test, 10 assertions)

Test is passing

acbramley’s picture

acbramley commented
Issue tags: -Needs tests

  • acbramley committed 1d3475fd on 2.x authored by elber 
    Issue #3348166 by elber, acbramley, solideogloria: Add a config form
acbramley’s picture

acbramley commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.