The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
In #3123832: [META] Fix @todo items referencing closed issues we discovered that there are a few @todos in our odebase which references a d.o. issue that is already closed: #3219959: Update standard profile so Olivero is the default theme.
Steps to reproduce
Proposed resolution
Basically all the @todos tell us to remove some modules from the modules-to-enable in a few different tests.
At the time of #3219959: Update standard profile so Olivero is the default theme, Olivero was not in the base profile and needed some modules to be enabled to make the theme testable.
Since then, Olivero made it as the base theme and all those "extra" modules are now enabled in the base profile, so there's no need any more to enable those individually in specific tests.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3347766.png | 21.71 KB | kleiton_rodrigues |
Issue fork drupal-3347766
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3347766-address-todo-comments-linking
changes, plain diff MR !3655
Comments
Comment #3
spokjeComment #4
smustgrave commentedLooks good
Comment #5
quietone commentedI applied this and grepped core for other instances of the closed issue. There were none. I think is ready for commit. I'll do that in a day, unless another committer disagrees.
Comment #6
kleiton_rodrigues commented@Spokje LGTM on remove:
RTBC +1
Comment #8
quietone commentedAlways pleasant to do a bit of cleanup.
Committed 8177e87 and pushed to 10.1.x. Thanks!