[1.0.x] Picture Everywhere

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, please update the issue summary to give the link to the correct project link and the issue title to contain that project name.

To the reviewers

Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

1. Fix PHPCS issues. You can use the PHPCS tool for checking and resolving issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml picture_everywhere/

FILE: picture_everywhere/picture_everywhere.module
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 32 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines
 46 | ERROR | The array declaration extends to column 113 (the limit is 80). The array content should be split up over multiple lines
 56 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: picture_everywhere/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  29 | ERROR | Missing @var tag in member variable comment
  34 | ERROR | Missing @var tag in member variable comment
 158 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
 232 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: picture_everywhere/src/Preprocess.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
  96 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 119 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

2. FILE: picture_everywhere.info.yml
- remove commented code

# test_dependencies:
#   - webp:webp

- Drupal 10 requires at least PHP 8.1. PHP 8.1.6 is recommended. PHP version requirement needs to be updated accordingly.

php: 8.0

@bvoynick,

I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Thanks

    foreach ($allowed_img_tags as $allowed_img_tag) {
      if (!preg_match('/^[^\t\n\f \/<>"\'=]+$/', $allowed_img_tag)) {
        $form_state->setErrorByName('output][img_tag_attributes', '"' . $allowed_img_tag . '" is not a valid HTML attribute.');
      }
    }

The second parameter passed to setErrorByName() needs to be a translatable string.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.