My installation uses the S3 filesystem for private files. Since I've updated to Drupal 9.5.4, I get
TypeError: Drupal\fillpdf\Plugin\PdfBackend\PdftkPdfBackend::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystem, Drupal\s3fs\S3fsFileService given

Probably related to https://www.drupal.org/project/printable/issues/3284183

CommentFileSizeAuthor
#4 3347444.patch2.37 KBranjit1032002

Issue fork fillpdf-3347444

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jglynn created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 5.1.0-beta1 » 5.1.x-dev

The type declaration probably has to be switched to FileSystemInterface.

It would be helpful to check if there are other places where a type declaration uses a class when it should use an interface.

Ranjit1032002 made their first commit to this issue’s fork.

ranjit1032002’s picture

ranjit1032002
Primary language English
Location India
commented
Status: Active » Needs review
StatusFileSize
new 3347444.patch2.37 KB

Created a patch for the issues mentioned, please review.
Thank You.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Needs work

Patch failed to apply. Please make sure the patch is against the branch tip of 5.1.x.

hardikpandya’s picture

hardikpandya commented
Assigned: Unassigned » hardikpandya

hardikpandya opened merge request !42

hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Needs work » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: S3 file system error » Replace use of FileSystem with FileSystemInterface

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.