Problem/Motivation

  1. There have been a few bug reports where site admins have accidentally removed the DefaultsEmailAdjuster policy and then been confused by the error they get.
  2. EmailBuilders may need to implement one type then provide legacy proxy for a different type (needed for #3271421: Full integration with commerce module)

Proposed resolution

  1. Add an EmailAdjuster annotation setting automatic that causes it to run always without needed a configured policy.
  2. Enhance EmailBuilder annotation setting proxy to allow it to take an array of email IDs to proxy.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 symfony_mailer.annotations.3346971-total.patch25.65 KBadamps
#8 symfony_mailer.annotations.3346971-8.patch7.7 KBadamps
#4 symfony_mailer.annotations.3346971-4.patch28.03 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Issue summary: View changes
adamps’s picture

adamps commented
Issue summary: View changes
adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new symfony_mailer.annotations.3346971-4.patch28.03 KB
adamps’s picture

adamps commented
Status: Needs review » Fixed

  • AdamPS committed 69922b0b on 1.x 
    Issue #3346971 by AdamPS: Enhancements to builder and adjuster...
adamps’s picture

adamps commented
Status: Needs review » Fixed
adamps’s picture

adamps commented
Issue summary: View changes
Status: Fixed » Needs review
StatusFileSize
new symfony_mailer.annotations.3346971-8.patch7.7 KB

This issue needs more work.

1) Some missing parts: update hook, config/schema changes.
2) Remove the 'internal' annotation, as I propose to get rid of SwiftmailerEmailBuilder anyway for #3315358: Allow full management of override plugins.
3) Undo some changes to EmailFactory that might cause BC problems without any benefit.

  • AdamPS committed 240e9f23 on 1.x 
    Issue #3346971 by AdamPS: Enhancements to builder and adjuster...
adamps’s picture

adamps commented
Status: Needs review » Fixed
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.annotations.3346971-total.patch25.65 KB

This issue was committed in two parts. This patch (hopefully😃) represents the combined change from both commits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.