
Problem/Motivation
The CSS file has a body style that messes up site styling and requires an override. There's also some linting issues with the CSS file, although those don't affect any functionality.
Composer puts the library in the wrong place (/libraries/easy-responsive-tabs-to-accordion), so we have to override that with a libraries-override in the theme.info.yml file to get things to even load.
Proposed resolution
The library has a MIT license and is 9+ years old, and likely will never be updated, so we might as well just put both the JS and CSS files in the asset folder and save us the headache of pulling in the library at all.
Comment | File | Size | Author |
---|---|---|---|
#3 | Desktop-screenshot (3).png | 86.17 KB | dharmeshbarot |
#2 | add-library-to-assets-folder-3346351-2.patch | 11.32 KB | davemybes |
Comments
Comment #2
davemybes CreditAttribution: davemybes as a volunteer commentedPatch file attached.
Comment #3
dharmeshbarot CreditAttribution: dharmeshbarot at Atlas Softweb Pvt Ltd commentedHello, #2 patch was applied successfully and working fine, moving to RTBC