Problem/Motivation

The site breaks when I have items in the cart and I try to change the currency on the currency block.
The currencies work as cookies and use the Automatic conversion source.

Specifically, if the item has overriden unit price, and the price is set to 0.

Steps to reproduce

  1. You must have some kind of custom code and at least one of the items unit price has to be set to overriden and to 0
  2. Go to cart page
  3. Change the price from the currency block

Proposed resolution

I have written a custom patch that prevents the WSOD, but sometimes it still messes up the currencies...

Without the patch, I have just edited the cookie storage and reverted back to the currency that was previously set

In the worst case if the site still breaks I had to programmatically delete order.

CommentFileSizeAuthor
price_resolver_wsod.patch1.11 KBdarko_antunovic

Comments

darko_antunovic created an issue. See original summary.

darko_antunovic’s picture

darko_antunovic
He/him
Primary language Serbian
commented
Title: WSOD when currency is changed, while having order items in cart » WSOD when currency is changed, while having order items with overriden unit price set to 0 in cart
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -Commerce (duplicate), -price, -currency, -multicurrency, -commerce_multicurrency, - +Commerce
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Active » Fixed

that' fixed with 3615986 in v2

tnx

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.