Problem/Motivation

LTR:

RTL:

Proposed resolution

Address these inconsistencies.

Remaining tasks

None

User interface changes

Before:

before

After:

after

API changes

None

Data model changes

None

Release notes snippet

CommentFileSizeAuthor
#11 3344765-after.png136.45 KBnayana_mvr
#11 3344765-before.png133.87 KBnayana_mvr
#6 3344765.jpg263.68 KBkleiton_rodrigues
#3 3344765-3.patch1.25 KBlauriii
#2 3344765-2.patch1.31 KBlauriii
#2 Screen Shot 2023-02-27 at 20.39.40.png122.07 KBlauriii
Screen Shot 2023-02-27 at 20.34.54.png119.7 KBlauriii
Screen Shot 2023-02-27 at 20.35.03.png120.25 KBlauriii

Issue fork drupal-3344765

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new Screen Shot 2023-02-27 at 20.39.40.png122.07 KB
new 3344765-2.patch1.31 KB

After this patch:

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3344765-3.patch1.25 KB

Removed some excess newlines from the patch.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community

After patch screenshot is already added. LGTM. moving to RTBC

kleiton_rodrigues’s picture

kleiton_rodrigues commented

The #3 patch applies cleanly and works as expected.
LGTM.

kleiton_rodrigues’s picture

kleiton_rodrigues commented
StatusFileSize
new 3344765.jpg263.68 KB

RTL LGTM

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3344765-3.patch, failed testing. View results

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

nayana_mvr made their first commit to this issue’s fork.

nayana_mvr opened merge request !9821

nayana_mvr’s picture

nayana_mvr commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3344765-before.png133.87 KB
new 3344765-after.png136.45 KB

Verified the patch on D11 and the changes applied cleanly. I have created an MR against 11.x branch with the changes in #3. Attaching before and after screenshots of D11 for reference. Please review.

Before:

before

After:

after

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

MR appears to be reroll of #3 https://www.drupal.org/files/issues/2023-02-27/3344765-3.patch which is fine just mentioning.

Issue is still resolved.

nod_ closed merge request !9821

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 7b2bc5c1e4 to 11.x and 2dd4b0a0c3 to 11.0.x and 3f77afc88b to 10.4.x and 76a7be52b3 to 10.3.x. Thanks!

nod_’s picture

nod_
Primary language French
Location Lille
commented

  • nod_ committed 76a7be52 on 10.3.x 
    Issue #3344765 by lauriii, nayana_mvr, kleiton_rodrigues, smustgrave:...

  • nod_ committed 3f77afc8 on 10.4.x 
    Issue #3344765 by lauriii, nayana_mvr, kleiton_rodrigues, smustgrave:...

  • nod_ committed 2dd4b0a0 on 11.0.x 
    Issue #3344765 by lauriii, nayana_mvr, kleiton_rodrigues, smustgrave:...

  • nod_ committed 7b2bc5c1 on 11.x 
    Issue #3344765 by lauriii, nayana_mvr, kleiton_rodrigues, smustgrave:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.