Problem/Motivation

The system will be broken when deleting the translation of the menu link.
Error message: The entity object refers to a removed translation (en) and cannot be manipulated.
see: #3187605: The site will be broken when deleting translation of menu link

Proposed resolution

Record menu link translation deletions instead of breaking the site

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ✅ Automated unit testing coverage
  • ✅ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release admin_audit_trail-1.0.10

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • fix: #3343561 Record menu link translation deletions instead of breaking the site
CommentFileSizeAuthor
#4 3343561-link-translation-issue-11.patch1.35 KBk9606
#3 3343561-link-translation-issue-2.patch1.35 KBk9606
#2 3343561-link-translation-issue-11.patch1.35 KBk9606

Issue fork admin_audit_trail-3343561

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

k9606 created an issue. See original summary.

k9606’s picture

k9606 commented
StatusFileSize
new 3343561-link-translation-issue-11.patch1.35 KB

reference resources: https://www.drupal.org/project/events_log_track/issues/3187605 #3

k9606’s picture

k9606 commented
StatusFileSize
new 3343561-link-translation-issue-2.patch1.35 KB

This is the wrong comment. Sorry, I can't delete it

k9606’s picture

k9606 commented
StatusFileSize
new 3343561-link-translation-issue-11.patch1.35 KB

This is the wrong comment. Sorry, I can't delete it

rajab natshah made their first commit to this issue’s fork.

rajab natshah opened merge request !33

rajab natshah’s picture

rajab natshah
he/him
commented
Title: The site will be broken when deleting translation of menu link » Record menu link translation deletions instead of breaking the site

  • rajab natshah committed e7e5b821 on 1.0.x 
    fix: #3343561 Record menu link translation deletions instead of breaking...
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » josebc
Issue summary: View changes
Status: Patch (to be ported) » Needs review
Issue tags: +admin_audit_trail-1.0.10
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: josebc » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released admin_audit_trail-1.0.10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.