When users see "start" and "end" date filters on a View, they think that if they want to see results from March 1, they should enter March 1 for both the start and end dates, but the date filter evaluates these as the same instant instead of 24 hours apart.
Create content with a date value during a certain date (say, noon on March 1) and index it. Search for that content using a date filter set to start and end on that date. The content will not appear because noon on March 1 is not between midnight and midnight on March 1. Now set the end date to March 2, and the content will be found.
A patch being developed for the core Views date filter at https://drupal.org/node/2982968 works very nicely to add a day to the max filter if it it submitted without a ":" character. However, this fix is in the getConvertedValues() method of the date filter object, and Search API's extension of the object does not call that method. Perhaps it would be better for compatibility to call the parent method, but I don't fully understand why the decision was made not to use it, so instead I will just add the code into the opBetween() method.
submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3343250-6--date_filter_max_inclusive.patch | 2.59 KB | drunken monkey |
| #6 | 3343250-6--date_filter_max_inclusive--tests_only.patch | 1.78 KB | drunken monkey |
Comments
Comment #2
benstallings commentedComment #3
benstallings commentedComment #4
benstallings commented(Incidentally, the patch above also silences a PHP warning that occurs if the value type isn't set. Extra credit)
Comment #5
benstallings commentedComment #6
drunken monkeyThanks a lot for posting this issue and providing a patch!
I could reproduce the problem, and indeed it seems clear that this deviates from the expected behavior. Your fix also seems sensible.
What was still missing, though, was a regression test which I have added in the attached patch. I also had a tiny nitpick about code style.
Please test/review and I can commit this.
Comment #8
benstallings commentedThanks for the code style fix. I'm afraid I don't understand how the regression test works, so I'm not qualified to review it. I hope someone else will review it for you.
Comment #10
drunken monkeyWell, I guess the regression test not being reviewed is not such a big deal, as long as it works as expected (as proven by the test bot).
So, committed. Thanks a lot again!