Problem/Motivation

I've got fairly simple setup in that I have some smartqueues based on a large-ish taxonomy.

When editing the taxonomy to re-order the terms we see incredibly high memory usage and timeouts.

Steps to reproduce

In the above setup, re-order some terms using the Drupal admin UI.

Proposed resolution

As far as I can see it's because if a term is updated, then the associated smartqueue is re-saved. This seems kinda wasteful. It sort of looks like the code is only trying to update the label.

I suppose that there could be other code that is triggering off of this update, so it's possible that we should:

* Stop the save
* Introduce another event
* Bump the API version.

Remaining tasks

Do all the above.

User interface changes

None.

API changes

We'd remove an entity update, and add a new event to cover this.

Data model changes

None.

CommentFileSizeAuthor
#2 entityqueue-3343208-slow-entity-updates.patch718 bytessteven jones

Issue fork entityqueue-3343208

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Steven Jones created an issue. See original summary.

steven jones’s picture

steven jones commented
Status: Active » Needs work
StatusFileSize
new entityqueue-3343208-slow-entity-updates.patch718 bytes

Here's a patch for point 1, it doesn't add the new event.

amateescu made their first commit to this issue’s fork.

amateescu opened merge request !50

  • amateescu committed 0b71eeb7 on 8.x-1.x 
    fix: #3343208 entityqueue_smartqueue_entity_update can be slow

By:...
amateescu’s picture

amateescu commented
Status: Needs work » Fixed

Merged a fix inspired by your patch, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.