Drupal 10 compatibility

I have read the code, and tested on a footnote-heavy node. It looks fine and should be merged.

Merge request functionally works as intended, there is only only issue with the "FootnotesFilterPluginTest". In D10 "classy" is deprecated so changed it to "stark". See the attached patch, which is derived from the MR.

-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8 || ^9 || ^10

Shouldn't D8 be removed from here? And a constraint on whichever point release of D9 added the services this patch uses added?

@rupertj A core_version_requirement of 8 is correct if it works on 8, as is core_version_requirement: ">=8". That is my reading of the documentation: https://www.drupal.org/node/3070687

If the module version does not work on 8, you are right. But I see no D8 incompatibilities when I read the code?

If we keep setting it back to "needs work" on the basis for a preference for a different style, we will never get a release. If you feel the improvement is useful enough to make a patch or MR I am happy to review again. I just don't want to be in the kind of limbo which afflicts some bike-shedded core tickets.

You're right, this will work on D8 from 8.7 onwards, when the extension.list.module service was added. (I read the change notice incorrectly and thought that was added in 9.3).

While we could specify ^8.7 in the core_version_requirement key, that was introduced in 8.7.7 and the old core key isn't there, so the module already states its compatibility correctly.

I'll set this back to RTBC.

It's time, D10.0.0 was released late 2022 and we've already got 10.1.0 since June.

Meanwhile we're using this:
add this section to repos

            "type": "package",
            "package": {
                "name": "drupaloverride/footnotes",
                "version": "dev-389813a1",
                "type": "drupal-module",
                "dist": {
                    "type": "zip",
                    "url": "https://git.drupalcode.org/api/v4/projects/project%2Ffootnotes/repository/archive.zip?sha=389813a1"
                }
            }
        },

Then:
composer require drupaloverride/footnotes

With that said, not sure how well the module works in D10 yet as we just started using it in D10.

Apologies if this is not the proper forum for this, but I have used Footnotes as an integral part of my website for, I think, 10 years now, and the lack of Drupal 10 support is currently the only thing that stops me from updating to Drupal 10. It appears that working patches exist for the module and have been reviewed and confirmed several times, so I am just curious as to why the module hasn't had a new release yet? Are there no active maintainers? I know of a few other modules with similar issues, and in those cases new maintainers were approved and could make a new release, as the existing maintainers had been inactive for too long.

#3248789: Offering to maintain Footnotes

This has been merged with the 3.1.x branch. I tested this on a D10 site and it works as expected. The 3.1.x branch now supports both CKE4 and CKE5 on D10.

Thanks for getting this merged. Could we get a stable release cut for this?

@smulvih2 , just noticed, there's no 3.0.x-dev release for this project, only a tagged release from 2021 about 2 years ago.
Until a dev release is made available, anyone wanting to use this project needs to clone the repo basically and check out that branch.

I was only given co-maintainer role, so can't make a new release. I have asked the maintainer to either give me maintainer role or make a tagged release based on 3.0.x - https://www.drupal.org/project/footnotes/issues/3248789#comment-15178771

I will push a release for this ASAP.

@smulvih2 , ok, I'll ask Pifagor to augment your power

We also tested this and works as expected. We are also interested in a stable release asap. Thank you!

I went and created a dev branch release of the 3.1.x version, I'll ask forgiveness for doing so. We needed something to test while we wait for a stable release (which is still needed and wasn't something I was going to do).

@dave thanks for doing this. I created a 3.1.0-alpha1 tag but the dev release is better until I get access to make a full release.

Release 3.1.0 is now available.

w00t! Thank you @Dave Reid and @smulvih2 and @Adrian_S_M , @adam-delaney and @pifagor, especially thanks to @smulvih2 for taking the bull by the horns ! :)