In current state are permissions for use 'authenticated' for Search form and Administer site configuration for config form. I think, that this module will need custom permissions.

Issue fork chatgpt_plugin-3343129

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

siva01 created an issue. See original summary.

siva01 opened merge request !8

anup.sinha’s picture

anup.sinha commented

Hi @siva01, First of all many thanks for checking out my module.

I wanted to keep the configuration as simple as possible. Below are the explanation for my permission -

1. I would not want to give access to the API config page anyone except site administrator as it has the secret access token.
2. For a blog or forum site, authenticated users also need to have the access to the content creation page.

Now if we add custom permission, people also need to check permissions for different role like authenticated users from the permissions page to make this module work which will overcomplicate the configuration part as per my opinion.

So request you to provide more explanation or a scenario when we need a custom permission for this module. This will help me to analyse your requirement.

Thanks & Regards,
Anup

siva01’s picture

siva01 commented

I added separated permissions for configuration and usage. You can check my MR on https://git.drupalcode.org/project/chatgpt_plugin/-/merge_requests/8

Why we need more permissions: for example in our system we have some roles, which can use ChatGPT search: author, lectors, publishers. But we have also api users, which are authenticated, but hasn't rights for create any content. They shoudln't has right to use ChatGPT search to0.

Ad configuration: I can imagine, that only super admin can have right to edit token, but some lower admin could have right edit another config, as start text, stop words, temperature, length,. We have admin for every project and I can imagine, that every project/domain can have different settings.

anup.sinha’s picture

anup.sinha commented

Hi @siva01, I already checked your merge request. As per your merge request, "use chatgpt search form" permission will allow users to use the ChatGPT search form. By default for all the custom permissions, it will be checked for the admin roles in permission page. So for your custom "use chatgpt search form" permission still admin users need to go to the permission page and need to check it for authenticated users. Otherwise authenticated users will not be able to access it and that is why I said that it will overcomplicate the configuration part.

I understood your point regarding API users, let me check what could be the best solution.

Thanks & Regards,
Anup

anup.sinha’s picture

anup.sinha commented

Hi @siva01, many thanks for this change request and working on it. I have found lot of scenarios where we don't need this chatgpt api call access to authenticated users. So you are absolutely right that we need custom permission to manage the access efficiently. So I will review your change request and will merge it.

Thanks & Regards,
Anup

anup.sinha’s picture

anup.sinha commented
Status: Active » Fixed

Hi @siva01, your changes have been incorporated now into the dev branch by doing little bit of text changes. Thanks again for suggesting this change. Really appreciate your efforts.

Thanks & Regards,
Anup

anup.sinha’s picture

anup.sinha commented
Status: Fixed » Closed (fixed)
ressa’s picture

ressa
he/him
commented

Thanks @siva01 and @anup.sinha. It does look like 'Welcome to the ChatGPT' got re-reverted again, and is now back :)

https://git.drupalcode.org/project/chatgpt_plugin/-/blob/1.0.x/chatgpt_p...

ressa’s picture

ressa
he/him
commented

Also, I get this error with the latest dev-version:

The service "chatgpt.subscriber" has a dependency on a non-existent service "content_translation.manager".

It's best to leave issues at "Fixed", so that details like this can be caught before the issue finally closes itself and changes Status to "Closed (fixed)" automatically after 14 days. From Issue etiquette > Things not to do in issues:

12. Don't: Change the status of an issue from "Fixed" to "Closed (fixed)". An issue with the status "Fixed" will be automatically closed as fixed and removed from the list of open issues after 14 days. It should remain open for 14 days after being "Fixed" to cater for regressions and other unintended consequences of the fix.

anup.sinha’s picture

anup.sinha commented

Hi @ressa, I will keep this in mind going forward. Also dev branch is in active development state, so apology for the issue. Now it has been fixed , please try again.

Also added two new features -

1. Content translation -> if you go to the content translate tab, you will see a chatgpt translation link for simple text content translation.
2. OpenAI assistance tool -> in admin section, you will see a link for OpenAI Assistance Tool where you will be able to generate images from text using DALL.E model.

Request you to validate this new feature and share your feedback.

Thanks,
Anup

ressa’s picture

ressa
he/him
commented

Thanks @anup.sinha for clearing that up. I was a bit too fast, sorry about that.

the module now installs fine after your update. It does make sense that the module is under heavy development, and occasionally in flux between states. Thanks for the great work, I am very grateful for it.

It's very cool with the two new features! I will try them out as soon as I have time. Maybe the "OpenAI Assistance Tool" should be placed under /admin/content/ since it's actually generating content?

PS. The "OpenAI Assistance Tool Add to Default shortcuts" button is named "Search" :)

anup.sinha closed merge request !8