Documentation: https://www.drupal.org/node/2514612#s-drupal-9-compatibility

It is better not to provide a drupal/core version requirement in composer.json because Drupal's composer facade will generate the appropriate metadata based on the info.yml file.

Issue fork views_timelinejs-3342929

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

annmarysruthy made their first commit to this issue’s fork.

annmarysruthy’s picture

annmarysruthy commented
Assigned: Unassigned » annmarysruthy

annmarysruthy opened merge request !4

annmarysruthy’s picture

annmarysruthy commented
Assigned: annmarysruthy » Unassigned
Status: Active » Needs review

Created MR !5 for removing drupal core from require section of composer.json. please review the MR

dcam’s picture

dcam commented
Status: Needs review » Needs work

@annmarysruthy I don't know what went wrong with your MR, but there are no changes in it. Note that it says there's a merge error. I tried to figure out why and what I could do about it, but was unable.

annmarysruthy opened merge request !5

annmarysruthy’s picture

annmarysruthy commented

@dcam Can you please review MR !5 not MR !4

annmarysruthy’s picture

annmarysruthy commented
Status: Needs work » Needs review
hardikpandya’s picture

hardikpandya commented
Status: Needs review » Reviewed & tested by the community

MR 5 looks good. Marking as RTBC.

dcam’s picture

dcam commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.