Problem/Motivation

Without this module enabled, Drupal Core uses some special processing:

  1. If the comment author is anonymous, display the "Author name"
  2. If the subject field is a link to the entity, use the permalink

Proposed resolution

We should override the formatter output to match this. Use hook_preprocess_HOOK().

We should fix #3342452: TitleFormatter should extend StringFormatter first, because currently rendering has been forced which makes it hard to override.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 manage_display.comment-fields.3342671-10.patch4.9 KBadamps
#8 manage_display.comment-fields.3342671-8.patch4.91 KBadamps
#6 manage_display.comment-fields.3342671-6.patch4.96 KBadamps
#4 manage_display.comment-fields.3342671-interdiff-3-4.txt2.47 KBadamps
#4 manage_display.comment-fields.3342671-4.patch5.46 KBadamps
#3 manage_display.comment-fields.3342671-3.patch2.76 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Issue summary: View changes
adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new manage_display.comment-fields.3342671-3.patch2.76 KB
adamps’s picture

adamps commented
StatusFileSize
new manage_display.comment-fields.3342671-4.patch5.46 KB
new manage_display.comment-fields.3342671-interdiff-3-4.txt2.47 KB

Add a test

Status: Needs review » Needs work

The last submitted patch, 4: manage_display.comment-fields.3342671-4.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new manage_display.comment-fields.3342671-6.patch4.96 KB

Re-roll of the same patch. It works locally.

Status: Needs review » Needs work

The last submitted patch, 6: manage_display.comment-fields.3342671-6.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new manage_display.comment-fields.3342671-8.patch4.91 KB

Status: Needs review » Needs work

The last submitted patch, 8: manage_display.comment-fields.3342671-8.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new manage_display.comment-fields.3342671-10.patch4.9 KB

The tests work locally so I'm guessing - sorry for the churn

Status: Needs review » Needs work

The last submitted patch, 10: manage_display.comment-fields.3342671-10.patch, failed testing. View results

adamps’s picture

adamps commented
Version: 2.0.x-dev » 2.1.x-dev
Status: Needs work » Needs review
adamps’s picture

adamps commented

  • AdamPS committed 7a205623 on 2.1.x 
    Issue #3342671 by AdamPS: Override field output for comment base fields
adamps’s picture

adamps commented
Status: Needs review » Fixed
adamps’s picture

adamps commented
Version: 2.1.x-dev » 3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.