Problem/Motivation

TitleFormatter currently extends from BasicStringFormatter. However StringFormatter would be a much better starting point as it already has one of the settings that TitleFormatter is adding.

The code in StringFormatter has some improvements

  1. Doesn't force the link render array to string in viewElements().
  2. Correctly handles revisions.

Unfortunately the setting in StringFormatter has a different name: link_to_entity instead of linked.

Proposed resolution

  1. Change TitleFormatter to extend StringFormatter.
  2. Write an update hook to fix the setting name in existing display settings.

Remaining tasks

User interface changes

Slight differences in formatter settings.

API changes

None

Data model changes

Change of formatter setting name link_to_entity instead of linked.

Comments

AdamPS created an issue. See original summary.

adamps’s picture

Issue summary: View changes
adamps’s picture

Status: Active » Needs review
StatusFileSize
new5.23 KB

  • AdamPS committed 792b89b9 on 2.1.x
    Issue #3342452 by AdamPS: TitleFormatter should extend StringFormatter
    
adamps’s picture

Status: Needs review » Fixed
adamps’s picture

Version: 2.0.x-dev » 2.1.x-dev
adamps’s picture

Version: 2.1.x-dev » 3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.