By bnjmnm on
Change record status: 
Published (View all published change records)
Project: 
Drupal core
Introduced in branch: 
10.1.x
Introduced in version: 
10.1.0
Issue links: 
https://www.drupal.org/node/3331835
Description: 

Previously, FunctionalJavascript tests would fail if errors were thrown by Drupal.throwError(). However, JavaScript errors not thrown by Drupal.throwError() could occur and the test would still pass.

This has been changed, and FunctionalJavascript tests will now fail on any JavaScript error thrown during a test run.

Potential Impacts

Module and theme maintainers may experience new FunctionalJavascript test failures if they have tests where JavaScript errors are occurring. This can be addressed by one of two things:

  • Addressing the underlying JavaScript errors (that were already happening, but are now caught by tests)
  • Configuring the test to not fail on JavaScript errors by setting $this->failOnJavascriptConsoleErrors = FALSE;, and addressing the JavaScript errors when time permits.

,

Impacts: 
Module developers
Themers