GitLab CI reports PHP_CodeSniffer warnings/errors which should be fixed.

CommentFileSizeAuthor
#4 Capture.PNG5.87 KBcharchil khandelwal
#2 3341786-2.patch14.45 KBsahil.goyal

Issue fork form_mode_control-3341786

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sahil.goyal created an issue. See original summary.

sahil.goyal’s picture

sahil.goyal commented
Status: Needs work » Needs review
StatusFileSize
new 3341786-2.patch14.45 KB

Uploading patch to fix all the php coding standard issues and warnings.

Please review.

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: Unassigned » charchil khandelwal

I will review this.

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: charchil khandelwal » Unassigned
StatusFileSize
new Capture.PNG5.87 KB

Patch #2 tested and applied clearly, all the errors and warnings are fixed now.
RTBC +1.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standards Issues | phpcs » Fix the issues reported by phpcs
Issue tags: -Drupal Coding Standards Issues | phpcs

silvi.addweb made their first commit to this issue’s fork.

silvi.addweb opened merge request !11

apaderno opened merge request !12

silvi.addweb’s picture

silvi.addweb commented

Fixed the below-mentioned errors. and raised Mr for the same.

FILE: /home/addweb/Drupal8-vagrant/web/web/patches/form_mode_control/src/Form/FormModeConfigForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeBundleInfoInterface.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/addweb/Drupal8-vagrant/web/web/patches/form_mode_control/src/FormModePermission.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: Bug report » Task
Issue summary: View changes
clarkssquared’s picture

clarkssquared commented

Hi

I applied MR !11 and it fixes all the PHPCS issues, I will retaing the status to needs review so that others can give their feedback.

➜  form_mode_control git:(8.x-2.3) ✗ curl https://git.drupalcode.org/project/form_mode_control/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15224    0 15224    0     0  21405      0 --:--:-- --:--:-- --:--:-- 21625
patching file form_mode_control.module
patching file form_mode_control.routing.yml
patching file 'src/Form/FormModeConfigForm.php'
patching file 'src/FormModePermission.php'
➜  form_mode_control git:(8.x-2.3) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml form_mode_control
➜  contrib git:(master) ✗
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

dieterholvoet made their first commit to this issue’s fork.

dieterholvoet closed merge request !12

dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Needs work

Thanks for your contributions! Seems like some more issues turned up in the pipeline though, so going to leave this open.

dieterholvoet opened merge request !18

dieterholvoet’s picture

dieterholvoet commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • dieterholvoet committed 41b4714c on 8.x-2.x 
    Issue #3341786 by dieterholvoet: Fix the issues reported by phpcs

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.