Drupal Coding Standards Issues | phpcs
FILE: /taxonomy_delete/taxonomy_delete.drush.inc
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
31 | ERROR | [x] Whitespace found at end of line
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------
FILE: /taxonomy_delete/src/Form/TaxonomyDeleteUIForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------
FILE: /taxonomy_delete/src/TermDelete.php
---------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace declaration
10 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
12 | ERROR | [x] Whitespace found at end of line
19 | ERROR | [x] Whitespace found at end of line
26 | ERROR | [x] Whitespace found at end of line
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | coding-standard-3341465-2.patch | 1.63 KB | omkar_yewale |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !12changes, plain diff MR !4
Comments
Comment #2
omkar_yewale commentedPlease Review this Patch.
Comment #5
sahil.goyal commentedApplied the #2 resolved all the php coding standard Issues/warnings, creating MR
moving to RTBC, Thanks.
Comment #6
abelcain commentedDear @sahil.goyal,
I did a review of phpcs and phpmd in the issue https://www.drupal.org/project/taxonomy_delete/issues/3341043
If you agree, we can focus on that review, I can give you contribution to the commits of phpmd and phpcs. Just help me review that ticket and move forward so we have module ported to D10 and with correction of standards.
If it's ok to you, we can close this ticket as duplicated, and you can get the Port to D10 issue to review it.
Kind regards
Abel S.
Comment #9
astonvictor commentedThe MR is merged. Fixed all CS issues.