With the latest 1.9.17 release of phpstan/phpstan and the latest 1.1.29 release of mglaman/phpstan-drupal we see our "updated deps" test-runs fail on both 10.0.x and 10.1.x
https://www.drupal.org/node/3060/qa
Bump phpstan/phpstan and mglaman/phpstan-drupal to their latest version (including upping the version constraint in composer.json) AND refresh the baseline at the same time.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
spokjeComment #4
spokjeComment #6
spokjeMR !3459 =>
10.0.xMR !3456 =>
10.1.xComment #7
spokjeComment #8
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #9
spokjeneeds-review-queue-bothas problems with issue spanning over more than one branch.Telling it to ignore this issue with a friendly
get-lost!!!no-needs-review-bottagComment #10
mondrakeLooks good to me - probably needs a reroll for the composer lock hash though.
Comment #11
spokjeThanks @mondrake, checking for the need of rerolls now.
Comment #12
spokjeCurrently both MRs for 10.0.x and 10.1.x are passing
Comment #13
catchNeeds a rebase.
Comment #14
mondrakeNeeds a rebase again, and in the meantime PHPStan is at 1.10.1
Comment #16
longwaveRebased and updated PHPStan in both branches, didn't regenerate the baseline but will see what failures come out.
Comment #17
longwavePushed baseline updates and a fix to ReverseContainer for both branches.
Comment #18
mallezieThis looks perfect! Only removal of things, without changing code, thus only removal of false positives.
Comment #19
catchSorry all, this already needs another rebase - committed some other baseline fixes in a different issue this morning :/
If someone pings me after the next rebase I'll insta-commit.
Comment #20
longwaveRebased and pushed both branches again.
Comment #23
catchOK this time! Committed/pushed to 10.1.x and 10.0.x respectively, thanks!
Comment #24
longwave