This is the companion issue to #3188474: Move the config_enforce form to an off-canvas dialog because a lot of the form code is actually in Config Enforce, with Config Enforce Devel extending and building on top of said form code.

Problem/Motivation

See #3188474: Move the config_enforce form to an off-canvas dialog

Steps to reproduce

Use eyeballs.

Proposed resolution

Phase 1 in the the 1.0.x branch is to move the floating window into the normal flow of the parent form and wrap it in a a '#type' => 'details' along with some other minor improvements (such as adding an icon).

Phase 2 will be in the 2.x branch where we'll refactor it as a standalone form that's progressively enhanced in a Drupal dialog opened and submitted via Ajax.

Remaining tasks

TBD.

User interface changes

Here are some work in progress screenshots. First is with the details element collapsed (the default on loading a form):

A screenshot of the Basic site settings administration page with the Config Enforce details element (closed) at the top of the form.

Here it is expanded:

A screenshot of the Basic site settings administration page with the Config Enforce details element (expanded) at the top of the form.

And yes, it works correctly on right to left language direction as well:

A screenshot of the Basic site settings administration page with the Config Enforce details element at the top of the form in right-to-left language direction.

See #3188474: Move the config_enforce form to an off-canvas dialog for what it looks like when Config Enforce Devel is installed.

API changes

Hopefully none, but will probably deprecate a method or two used for the floaty form to be removed later.

Data model changes

None.

CommentFileSizeAuthor
#22 config-enforce-alpha3-after.png62.14 KBstar-szr
#22 config-enforce-alpha3-before.png67.62 KBstar-szr
#7 config_enforce-3341143-7-system.site-expanded.png101.04 KBambient.impact
#3 config_enforce-3341143-system.site-rtl.png103.46 KBambient.impact
#3 config_enforce-3341143-system.site-expanded.png101.18 KBambient.impact
#3 config_enforce-3341143-system.site-collapsed.png102.41 KBambient.impact

Issue fork config_enforce-3341143

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ambient.Impact created an issue. See original summary.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Parent issue: » #3305516: Config Enforce roadmap
ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Issue summary: View changes
StatusFileSize
new config_enforce-3341143-system.site-collapsed.png102.41 KB
new config_enforce-3341143-system.site-expanded.png101.18 KB
new config_enforce-3341143-system.site-rtl.png103.46 KB
ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Issue summary: View changes

Ambient.Impact opened merge request !10

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Status: Active » Needs review

Fixed failing test woooooo.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Issue summary: View changes
StatusFileSize
new config_enforce-3341143-7-system.site-expanded.png101.04 KB

Updated expanded screenshot with enforcement levels background colour ported over.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Version: 1.0.x-dev » 2.0.x-dev
Status: Needs review » Postponed

1.0.x changes have been merged. Changing version to 2.0.x and postponing for the second phase to be done at a later date.

ergonlogic made their first commit to this issue’s fork.

ergonlogic opened merge request !31

  • star-szr committed 6b0b4e3a on 2.0.x 
    [#3341143] fix: Remove stale CSS that is now applying to our new form...
star-szr’s picture

star-szr
he/him
Primary language English
commented
Title: Improve usability of Config Enforce UI » Add indicator(s) to each config form to reflect the enforcement status
Status: Postponed » Active

The main goal of this issue has already been accomplished: The off-canvas dialog aspect is being fully handled by Config Enforce Devel, and has been merged in #3188474: Move the config_enforce form to an off-canvas dialog.

We will therefore narrow the scope here to just output an indicator, because this hasn't been handled yet and is a regression in terms of UI/UX.

Any further UI improvements will be handled in standalone tickets such as #3556490: Update the enforced configs table via AJAX (when using off-canvas dialog).

  • star-szr committed d8922c14 on 2.0.x 
    [#3341143] fix: Ensure container is not output when CED is not installed...

  • star-szr committed fe0dcbf7 on 2.0.x 
    [#3341143] refactor: Clarify logic when enforcing forms

By: ergonlogic...

  • star-szr committed ff8e38f7 on 2.0.x 
    [#3341143] fix: Remove duplicate container class on details element

By...

  • star-szr committed 22c12f54 on 2.0.x 
    [#3341143] refactor: Remove unused CSS

By: ergonlogic
By: star-szr

  • star-szr committed ce450d65 on 2.0.x 
    [#3341143] feat: Allow easier overriding of the indicator by Config...

  • star-szr committed 4720c213 on 2.0.x 
    [#3341143] fix: Add back container and data loss warning message

By:...

  • star-szr committed e51cc001 on 2.0.x 
    [#3341143] feat: Add new indicator to go with off-canvas dialog

By:...
star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

star-szr’s picture

star-szr
he/him
Primary language English
commented
StatusFileSize
new config-enforce-alpha3-before.png67.62 KB
new config-enforce-alpha3-after.png62.14 KB

Uploading some screenshots to use in release notes.

  • star-szr committed 62708b74 on 2.0.x 
    [#3341143] refactor: Address TODO about translatable strings

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.