Problem/Motivation

In #3123832: [META] Fix @todo items referencing closed issues we discovered that there's a @todo in \settings_tray_install which references a d.o. issue that is already closed: #2783791: Module install doesn't invalidate render cache.

Here's the @todo:

  // This module affects the rendering of blocks and of the page.
  // @todo Remove in https://www.drupal.org/node/2783791.
  Cache::invalidateTags(['rendered']);

Steps to reproduce

Proposed resolution

#2783791: Module install doesn't invalidate render cache was marked as Closed (cannot reproduce). Although the approach in #2783791-40: Module install doesn't invalidate render cache might still be valid nowadays, the issue lost track years ago, so it looks like there's not much community interest.

Besides that several Core module install hooks have the mentioned line of (Cache::invalidateTags(['rendered']);), so there's no need to mark the install hook of the settings_tray one as special

I think we can safely remove the @todo lines from the settings_tray_install hook.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3341113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Version: 10.0.x-dev » 10.1.x-dev
Issue summary: View changes

spokje’s picture

Status: Active » Needs review
spokje’s picture

Issue summary: View changes
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Yea makes sense to remove if the ticket is closed.

catch’s picture

Status: Reviewed & tested by the community » Needs work

We need to remove the thing the @todo is saying to remove as well as the @todo.

spokje’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Looks good but appears to be a CI failure.

_pratik_ made their first commit to this issue’s fork.

spokje’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 10.1.x, thanks!

  • longwave committed e1673dd6 on 10.1.x
    Issue #3341113 by Spokje, _pratik_, smustgrave, catch: Remove @todo-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.