Problem/Motivation
In #3123832: [META] Fix @todo items referencing closed issues we discovered that there's a @todo in \settings_tray_install which references a d.o. issue that is already closed: #2783791: Module install doesn't invalidate render cache.
Here's the @todo:
// This module affects the rendering of blocks and of the page.
// @todo Remove in https://www.drupal.org/node/2783791.
Cache::invalidateTags(['rendered']);
Steps to reproduce
Proposed resolution
#2783791: Module install doesn't invalidate render cache was marked as Closed (cannot reproduce). Although the approach in #2783791-40: Module install doesn't invalidate render cache might still be valid nowadays, the issue lost track years ago, so it looks like there's not much community interest.
Besides that several Core module install hooks have the mentioned line of (Cache::invalidateTags(['rendered']);), so there's no need to mark the install hook of the settings_tray one as special
I think we can safely remove the @todo lines from the settings_tray_install hook.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3341113
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3341113-remove-todo-comment-linking
changes, plain diff MR !3448
Comments
Comment #2
spokjeComment #4
spokjeComment #5
spokjeComment #6
smustgrave commentedYea makes sense to remove if the ticket is closed.
Comment #7
catchWe need to remove the thing the @todo is saying to remove as well as the @todo.
Comment #8
spokjeComment #9
smustgrave commentedLooks good but appears to be a CI failure.
Comment #11
spokjeComment #12
smustgrave commentedComment #13
longwaveCommitted and pushed to 10.1.x, thanks!