Problem/Motivation

In https://github.com/goalgorilla/open_social/pull/394 we originally made the private file system opt-in. However, we recommend that everyone installs this and from a security perspective it's an important part of how Open Social works. Additionally the config overrides were causing some problems because changing the uri_schema for an image field has side-effects when done through the entity, but those side-effects are not properly applied when done through a config override.

When these side-effects are not applied we see hard to debug bugs like a missing default profile image. The suspicion is that the field config save is triggered with config that doesn't match the override, which causes the underlying image to be moved and the default image URI to be updated, however we've only been able to manually reproduce this by saving the FieldConfig item in code and then resetting the database (breaking the field image link).

Steps to reproduce

Proposed resolution

Make the private file system opt-out and prevent installation if the file-system is not configured properly. This allows us to deprecate the social_file_private module in 11.x, uninstall it in 12.0.0 and remove it in 13.0.0

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Kingdutch created an issue. See original summary.

tbsiqueira’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.