Employees of Dotsquares are posting mass re-roll patches which are invalid and/or incomplete

The worst example of this is when it breaks an existing patch, for example:

- a patch a couple of months old against 9.5.x, that still applies against 10.1.x
- instead of retesting the patch against 10.1.x, a 're-roll' is posted that doesn't include new files from the original patch. This can either result in failing tests, or new tests going missing etc.

You then have to compare the old and new versions of the patch to see what information has been lost, when the original patch was fine.

Sometimes new (or even old) contributors post unnecessary re-rolls or make mistakes, but this is happening across hundreds of issues at scale and is actively making things worse. Various people have noticed these issues in the re-rolls and pointed them out on-issue, but that feedback hasn't been taken on so there is a continuous barrage of more incomplete/wrong re-rolls.

Less bad is re-posting an identical patch to a previous one, but that still adds noise to the issue especially with the frequency it's being done.

I've manually removed core commit credit from the following already-committed issues so far this morning after doing some spot-checks:

https://www.drupal.org/project/drupal/issues/2787529#comment-14809605
https://www.drupal.org/project/drupal/issues/3178919#comment-14824904
https://www.drupal.org/project/drupal/issues/3266688#comment-14787801
https://www.drupal.org/project/drupal/issues/3191623#comment-14823521
https://www.drupal.org/project/drupal/issues/2991232#comment-14791662

Adding to the list

https://www.drupal.org/project/drupal/issues/2329937#comment-14910269

Missing changes in single patch

core/lib/Drupal/Core/Field/TypedData/FieldDefinitionOptionsProviderTrait.php
core/lib/Drupal/Core/Field/TypedData/FieldStorageDefinitionAwareOptionsProviderInterface.php
core/lib/Drupal/Core/Field/TypedData/FieldStorageDefinitionAwareOptionsProviderTrait.php
core/lib/Drupal/Core/Field/TypedData/LegacyOptionsProvider.php
core/lib/Drupal/Core/Plugin/Context/ContextAwareOptionsProviderInterface.php
core/lib/Drupal/Core/TypedData/Options/CallableOptionsProvider.php
core/lib/Drupal/Core/TypedData/Options/DefinitionAwareOptionsProviderInterface.php
core/lib/Drupal/Core/TypedData/Options/DefinitionAwareOptionsProviderTrait.php
core/lib/Drupal/Core/TypedData/Options/DependentOptionsProviderInterface.php
core/lib/Drupal/Core/TypedData/Options/OptionsProviderResolver.php
core/lib/Drupal/Core/TypedData/Options/SimpleOptionsProviderBase.php
core/modules/system/src/Tests/TypedData/OptionsProviderTest.php

Note also #3328723: Company incorrectly claiming to have multiple core committers.

Related slack discussion

https://drupal.slack.com/archives/C0451JV7HRD/p1675761259375699?thread_t...

Hello,

Maybe each company doing these practices will be discuss separately. As a module maintainer I've seen some other companies constantly monitoring coding standards in order to make an automatic fix and send the patch.

for example https://www.drupal.org/project/href_lang_exchange/issues/3285041#comment...

One more

https://www.drupal.org/project/drupal/issues/2802837#comment-14910809

This patch doesn't belong to the issue in which it was posted.

It appears that they recently qualified and paid for gold tier (as of around Feb. 3 2023).
https://www.drupal.org/node/3225823/revisions/view/12926828/12956364

I do not think a company should be eligible for certified partner tiers when it engages in this sort of disruptive issue queue behavior.

I am working with our partner team to schedule a conversation with their company leadership.

Thank you, @BramDriesen - I forgot to loop back around here.

Adding another case as suggested on Slack

https://www.drupal.org/project/drupal/issues/3107548#comment-14829959

Now the open issues are like #3343900: Implement hook_help(), which is created just to copy a sentence without even checking it makes sense, grammatically or not.

I can understand the willingness to help, but project maintainers do not need a patch or a MR to copy a single sentence from the project page; they could have done that by themselves, if they wanted.

That is similar to those patches whose purpose is just to remove the LICENSE.txt file. For a project maintainer, it costs less time to remove that single file without using MRs or patches.

Got a new readme update #3343722: Clean up documentation

To be positive it's only been about 2 in the last week or two so drastic improvement from before.

Hopefully don't jinx it but dotsquared seems to have stopped posting. Should this be closed out?

I guess we can close this.