Add support for Drupal 10

Issue fork log_stdout-3339853

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Maico de Jong created an issue. See original summary.

maico de jong’s picture

Status: Active » Needs review
StatusFileSize
new811 bytes

Module works fine on Drupal 10 with a small change mentioned in #3272447: Update to PSR/log v3

hardikpandya’s picture

StatusFileSize
new923 bytes

I was not able to apply the patch in #2. Got this error:

error: patch failed: log_stdout.info.yml:2
error: log_stdout.info.yml: patch does not apply

MakaziMtingwa made their first commit to this issue’s fork.

makazimtingwa’s picture

Created the issue fork to install this project in Drupal 10 with:
composer require drupal/log_stdout:dev-3339853-drupal-10-compatibility

At present, this will install patch #2. You may need to include patch #3 locally.

arturopanetta’s picture

I tested patch #2 and it works, I can redirect logs to stdout container. Patch #3 which I was unable to apply as it tries to remove some lines of code related to module versioning.

I used to:
- Drupal 10.0.9
- log_stdout branch 1.x
- patches #2

gigimaor’s picture

StatusFileSize
new1.2 KB

This one is working for me after upgrading to Drupal 10.

tolstoydotcom’s picture

The patch in #8 looks like it works. I also ran phpcs --standard=Drupal and didn't see any warnings.

jonmcl’s picture

Patch in #8 works with with the 8.x-1.3 branch, even though this issue is tagged with the 8.x-2.x-dev branch.

Update: Scratch that. Patch #8 only works with the 1.x-dev version (composer require 'drupal/log_stdout:1.x-dev@dev')

tolstoydotcom’s picture

8.x-2.x-dev (Last updated: 2 Sep 2020) is marked as only working with D8

8.x-1.x-dev (Last updated: 4 Oct 2021) is marked as working with ^8.8 || ^9 and the patch adds D10 compatibility. That's what I tested.

The main difference between the two dev versions seems to be that 2.x-dev uses a slightly different output format and it also adds user info to the output.

sudishth’s picture

StatusFileSize
new1.2 KB

reroll #8

sudishth’s picture

StatusFileSize
new1.28 KB

patch for 8.x-1.3

scarer’s picture

Yes #13 can confirm it works.

bladedu’s picture

Status: Needs review » Fixed

Merged and created release 1.4 which is D10 compatible.

Thank you!

rm-rf’s picture

I'm afraid you will still need to update the composer.json in order for this module to install correctly via Composer on a D10 install.

bladedu’s picture

Status: Fixed » Needs work

You are right. I didn't check the patch properly, I'm afraid.

  • Bladedu committed 4db07b8a on 8.x-1.x
    Issue #3339853: Drupal 10 compatibility
    
bladedu’s picture

it should be ok now in 1.4.1. sorry about that.

bladedu’s picture

Status: Needs work » Needs review
rm-rf’s picture

That looks good and the module now installs correctly via Composer on Drupal 10.

fraserthompson’s picture

Also confirming that the dev branch works with Composer on Drupal 10 but the current stable release doesn't and throws an error.

bladedu’s picture

I apologize for the inconvenience. I messed up with tag 1.4 and I couldn't amend it.

I've just releases 1.5 which can be pulled with latest Drupal 10 release.

pbonnefoi’s picture

Status: Needs review » Closed (outdated)
pbonnefoi’s picture

Status: Closed (outdated) » Fixed
pbonnefoi’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.