Problem/Motivation

hook_help function missing in .module file

CommentFileSizeAuthor
#12 Added suggestion.png239.72 KBa.aaronjake
#12 Help page.png286.84 KBa.aaronjake
#12 Implemented hook_help().png161.37 KBa.aaronjake

Issue fork message_notify-3339817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !9

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Created MR for the issue.
Please review.
Thanks

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: Unassigned » charchil khandelwal

I will review this.

charchil khandelwal’s picture

charchil khandelwal commented
Status: Needs review » Reviewed & tested by the community

MR !9 looks good to me.
So moving it to RTBC.

Thanks

bluegeek9’s picture

bluegeek9 commented
Assigned: charchil khandelwal » Unassigned
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work

The help text could be better.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: hook_help function missing in .module file » Implement hook_help()

thakurnishant_06 made their first commit to this issue’s fork.

thakurnishant_06’s picture

thakurnishant_06 commented
Status: Needs work » Needs review

Kindly review the changes.

bluegeek9’s picture

bluegeek9 commented
Status: Needs review » Needs work
thakurnishant_06’s picture

thakurnishant_06 commented
Status: Needs work » Needs review

Hi @bluegeek9 ,
Updated as per suggestion.

a.aaronjake’s picture

a.aaronjake commented
StatusFileSize
new Implemented hook_help().png161.37 KB
new Help page.png286.84 KB
new Added suggestion.png239.72 KB

Hi @thakurnishant_06,

Applied MR !9 against Message Notify 8.x-1.x-dev with Drupal Core 10.2.4, confirmed hook help and suggestion are added.
Will not change the status so others can review it.

Thank you.

a.aaronjake’s picture

a.aaronjake commented
Status: Needs review » Reviewed & tested by the community

bluegeek9’s picture

bluegeek9 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.