Problem/Motivation

The module description of the "flag_count" module says the following:

Provides an example on how to display flag counts

But this module provides a perfectly fine "Count link" link type which additionally displays the flag count together with the flag itself. The description of this type is:

An example AJAX action link which displays the count with the flag.

Which should be changed as well, because this flag type isn't an example.

Steps to reproduce

Proposed resolution

Fix the strings accordingly.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork flag-3339654

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Grevil created an issue. See original summary.

_pratik_ made their first commit to this issue’s fork.

ivnish’s picture

Status: Active » Needs work

Needs rebase

ivnish’s picture

Version: 8.x-4.x-dev » 5.x-dev
Issue tags: +Needs reroll
tanushree gupta’s picture

Assigned: Unassigned » tanushree gupta
tanushree gupta’s picture

Assigned: tanushree gupta » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll

Rerolled the MR.
Please review!!

ivnish’s picture

Status: Needs review » Needs work

Needs to fix phpcs warnings

ivnish’s picture

Issue tags: +Novice
santanu mondal’s picture

Assigned: Unassigned » santanu mondal
santanu mondal’s picture

Assigned: santanu mondal » Unassigned
Status: Needs work » Needs review

  • ivnish committed a20d612b on 5.x authored by _pratik_
    docs: #3339654 Fix misleading module description and link type...
ivnish’s picture

Status: Needs review » Fixed
Issue tags: -Novice

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.