Problem/Motivation

Two variables has same color hex code in the stylesheet at https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/themes/claro/css/base/variables.pcss.css.

--color-gray-050: #f3f4f9;
--color-blue-070: #f3f4f9;

Proposed resolution

Update color variable value.

CommentFileSizeAuthor
#4 3339559-4.patch980 bytessantosh_verma

Comments

Gauravvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Issue summary: View changes
gauravvvv’s picture

gauravvvv commented
Title: Claro: Update claro variable » Claro: Update claro color variables
santosh_verma’s picture

santosh_verma commented
Status: Active » Needs review
StatusFileSize
new 3339559-4.patch980 bytes

#Gauravvvv I have changed the --color-blue-070 color hex code according to Drupal Design system

reference link
https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/%F0%9F%92%A7-Drupal-...

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Change looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3339559-4.patch, failed testing. View results

santosh_verma’s picture

santosh_verma commented

working on it

santosh_verma’s picture

santosh_verma commented
Status: Needs work » Reviewed & tested by the community

I have initiated another test in queue. it's a random test failure and have no relation with my patch as their is no config change or any key change in the patch provided in #4. Hence reverting the status to the previous one (RTBC) changed by @smustgrave

please review.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

  • longwave committed e0d038f5 on 11.x 
    Issue #3339559 by Santosh_Verma, Gauravvvv: Claro: Update claro color...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Seems a straightforward fix, this colour isn't used anywhere that I can find so no need to backport and no visual checks to carry out.

Committed and pushed e0d038f582 to 11.x (10.2.x). Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.