Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 appliedMR.png2.06 MBroberttabigue
#8 withoutMR!1.png2.17 MBroberttabigue
#2 3339507-2.patch1.23 KBgayatri chahar

Issue fork locale_extend-3339507

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gayatri chahar created an issue. See original summary.

gayatri chahar’s picture

gayatri chahar commented
Assigned: gayatri chahar » Unassigned
Status: Active » Needs review
StatusFileSize
new 3339507-2.patch1.23 KB

Patch created. Please review it

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Unassigned » Sonal Gyanani

Sonal Gyanani opened merge request !1

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Sonal Gyanani » Unassigned

Patch #2 applied successfully, all unused imports are removed.
RTBC +1

schillerm made their first commit to this issue’s fork.

schillerm’s picture

schillerm commented

Hi, I went in to review MR!1 and noticed more unused imports in the module ..so removed them and pushed up the changes. Not sure if the /tests folder matters but decided to include unused imports found in there. Hope that's ok..

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new withoutMR!1.png2.17 MB
new appliedMR.png2.06 MB

Hi @gayatri

Applied the MR !1 new commits to the Locale Extend module with the
1.0.x-dev version and confirmed updated perfectly!.

Please see the attached files for your reference.

Thank you.

Jose Reyero made their first commit to this issue’s fork.

jose reyero’s picture

jose reyero commented

Thanks!

jose reyero’s picture

jose reyero commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.