Now that Drupal has official Javascript coding standards, we should make sure to follow them.

CommentFileSizeAuthor
#4 3339351-4--js_coding_standards.patch2.41 KBdrunken monkey
#4 3339351-4--js_coding_standards--interdiff.txt560 bytesdrunken monkey
#3 3339351-3--js_coding_standards.patch2.36 KBdrunken monkey
#3 3339351-3--js_coding_standards--interdiff.txt1.96 KBdrunken monkey
#2 3339351-2--js_coding_standards.patch2.45 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3339351-2--js_coding_standards.patch2.45 KB
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3339351-3--js_coding_standards--interdiff.txt1.96 KB
new 3339351-3--js_coding_standards.patch2.36 KB

Oops, seems I had `prettier` misconfigured.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3339351-4--js_coding_standards--interdiff.txt560 bytes
new 3339351-4--js_coding_standards.patch2.41 KB

And one more small change.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

A bit strange that the CI tool still reports a warning while it’s now green for me locally, but well, it’s at least definitely an improvement. If someone could tell me where the discrepancy is coming from I’d be delighted to be able to fix it. Otherwise, I’m just gonna go with my local check to enable me to set a Git pre-commit hook.

Anyways, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.