Problem/Motivation

Running a coding standards check reveals some issues:

> ./vendor/bin/phpcs -p --colors --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md ./web/modules/contrib/block_visibility_conditions
W.W.W.WE 8 / 8 (100%)



FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/modules/block_visibility_conditions_taxonomy/block_visibility_conditions_taxonomy.install
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 95 characters
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/modules/block_visibility_conditions_commerce/block_visibility_conditions_commerce.install
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 95 characters
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/modules/block_visibility_conditions_node/block_visibility_conditions_node.install
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 91 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/block_visibility_conditions.install
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 86 characters
 9 | WARNING | Line exceeds 80 characters; contains 81 characters
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/src/Plugin/Condition/NotConditionPluginBase.php
-------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------
 33 | ERROR | [x] Data types in @var tags need to be fully namespaced
 63 | ERROR | [x] Data types in @param tags need to be fully namespaced
 65 | ERROR | [x] Data types in @param tags need to be fully namespaced
 74 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

Issue fork block_visibility_conditions-3339129

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review

Added an MR fixing the issues. The version should be 2.x but I can only select 2.0 in the "Version" select.

matthiasm11 opened merge request !4

matthiasm11’s picture

matthiasm11 commented
Status: Needs review » Fixed

Thank you for your work. I created a merge request (I was able to select 2.x, I'm not sure what went wrong when you tried it) and merged the MR in 2.x. It will be available with the next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.