Problem/Motivation

Quoting #3252299-27: Reliably support cweagans/composer-patches in Package Manager & Automatic Updates: validate stage:

  1. doing a build test for composer-patches is something that would be good to have, but it's post-MVP

… to test:

    1. a core patch continues to be applied after updating core
    2. a core patch failing to apply provides a helpful UX
    3. a core patch failing to apply causes cron security updates to not get executed
    4. and perhaps more?

    This is postponed on #3338666: Add functional test that proves there is reasonable UX whenever a stage event subscriber has an exception.

    Steps to reproduce

    N/A

    Proposed resolution

    TBD

    Remaining tasks

    User interface changes

    TBD

    API changes

    None.

    Data model changes

    None.

Issue fork automatic_updates-3338667

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Wim Leers created an issue. See original summary.

Wim Leers opened merge request !685

Wim Leers credited kunal.sachdev.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Making sure @kunal.sachdev's pioneering work on this is not lost!

Cherry-picked the relevant commits from #3252299: Reliably support cweagans/composer-patches in Package Manager & Automatic Updates: validate stage's MR. 👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Add build test to test cweaganscomposer-patches end-to-end » [PP-1] Add build test to test cweagans/composer-patches end-to-end
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Version: 8.x-2.x-dev » 3.0.x-dev
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Add build test to test cweagans/composer-patches end-to-end » Add build test to test cweagans/composer-patches end-to-end
Status: Postponed » Active

#3252299: Reliably support cweagans/composer-patches in Package Manager & Automatic Updates: validate stage landed.

omkar.podey made their first commit to this issue’s fork.

omkar.podey’s picture

omkar.podey commented
Assigned: Unassigned » wim leers

It seems impossible to run composer config --no-plugins allow-plugins.cweagans/composer-patches true early enough.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Active » Closed (won't fix)
Related issues: +#3334914: Testing is broken because simplesamlphp/composer-module-installer contains a Composer plugin which is blocked

As described at #3334914: Testing is broken because simplesamlphp/composer-module-installer contains a Composer plugin which is blocked, this is not supported by/not allowed by DrupalCI.

We could switch to GitLab CI, but that's pointless, because we aim to add this module to Drupal core. And Drupal core won't be switching to GitLab CI for many months, possibly years.

So … we have only one choice: give up 🥲