All the modern browsers support display: flex and other related properties. We don't need -webkit-flex anymore.

Ref: https://caniuse.com/flexbox

.entity-moderation-form {
  display: -webkit-flex; /* Safari */
  display: flex;
  -webkit-flex-wrap: wrap; /* Safari */
  flex-wrap: wrap;
  -webkit-align-items: flex-start; /* Safari */
  align-items: flex-start;
  list-style: none;
}

.entity-moderation-form__item:last-child {
  -webkit-align-self: flex-end; /* Safari */
  align-self: flex-end;
  margin-right: 0;
}

Proposed resolution:

Remove these properties:

.entity-moderation-form {
  - display: -webkit-flex; /* Safari */
  display: flex;
  - -webkit-flex-wrap: wrap; /* Safari */
  flex-wrap: wrap;
  - -webkit-align-items: flex-start; /* Safari */
  align-items: flex-start;
  list-style: none;
}

.entity-moderation-form__item:last-child {
  -webkit-align-self: flex-end; /* Safari */
  align-self: flex-end;
  margin-right: 0;
}

Comments

Gauravvv created an issue. See original summary.

gauravvvv’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new812 bytes

I have provided a patch for same. Please review.

rinku jacob 13’s picture

StatusFileSize
new188.98 KB
new218.1 KB

Hi @Gauravvv , Verified and tested patch #2 on drupal version 10.1.x. The patch was successfully removed webkit properties from content_moderation.module.css file. Need RTBC +1

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems like a simple cleanup.

Good job!

lauriii’s picture

Status: Reviewed & tested by the community » Needs work

Closed #3338478: Stable: Remove webkit-specific display flex from CSS as a duplicate of this. We should implement the stable changes here.

gauravvvv’s picture

Status: Needs work » Needs review
StatusFileSize
new1.61 KB
new840 bytes

Removed the webkit properties from stable theme as well. Here is updated patch with interdiff please review

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Looks good!

longwave’s picture

Status: Reviewed & tested by the community » Fixed

@Rinku Jacob 13 there is no need to post screenshots of patches being applied, DrupalCI will tell us whether this is successful.

Committed and pushed to 10.1.x, thanks!

  • longwave committed f3af4a5f on 10.1.x
    Issue #3338552 by Gauravvv, lauriii: Remove webkit properties from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.