Problem/Motivation

Configuration can't be overridden via settings.php

Steps to reproduce

Within settings.php add something like

$config['raven.settings']['client_key'] = 'test test';

Proposed resolution

use \Drupal::config() instead of \Drupal::configFactory()->getEditable()

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork raven-3338496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ahmad Abbad created an issue. See original summary.

Ahmad Abbad opened merge request !10

ahmad abbad’s picture

ahmad abbad commented
Status: Active » Needs review
mfb’s picture

mfb
they or he
commented
Status: Needs review » Postponed (maintainer needs more info)

@Ahmad Abbad we just fixed this in #3335031: Overridden config should not be used as default values on settings page

You should be able to override the config via settings.php, it just will not show up on the config form.

And my understanding of how Drupal works is that config overrides are not supposed to show up on config forms, thus the fix in #3335031: Overridden config should not be used as default values on settings page

mfb’s picture

mfb
they or he
commented

See also the core bug report about this behavior: #2408549: Display status message on configuration forms when there are overridden values

mfb’s picture

mfb
they or he
commented

Meanwhile, I believe that tests are failing on this merge request due to test dependencies missing from the composer.json file?

  • mfb committed f3adea19 on 4.x 
    Issue #3338496 by mfb: Add test dependencies to composer.json

  • mfb committed 629a5326 on 3.x 
    Issue #3338496 by mfb: Add test dependencies to composer.json

  • mfb committed d115ebb9 on 8.x-2.x 
    Issue #3338496 by mfb: Add test dependencies to composer.json
mfb’s picture

mfb
they or he
commented
Category: Bug report » Support request
Status: Postponed (maintainer needs more info) » Fixed
Related issues: +#3335031: Overridden config should not be used as default values on settings page

Pretty sure this is working correctly, but feel free to re-open if I'm wrong :)

mfb closed merge request !10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.