Problem/Motivation
If you run phpcs with the "Drupal" rules provided by coder, there is an endless loop in includes/base.inc due to missing @endcode
In addition, drupal/coder requires @endcode to be on a different line, although arguably this latter issue is a bug in drupal/coder
Steps to reproduce
Can be reproduced in drupalci https://dispatcher.drupalci.org/job/drupal_d7/229934/console or manually via phpcs -v (with a phpcs.xml file that enables the "Drupal" rule).
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork ctools-3337800
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3337800-phpcs-endless-loop
changes, plain diff MR !41
- 7.x-1.x
changes, plain diff MR !42
1 hidden branch
Issue fork 2179357-3337800
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
joelpittetComment #3
joelpittetComment #7
joelpittetApparently I committed this fix already, what a mess I made of the MRs...
Fixed in
a6bbe8a1