With the 1.1.27 release of mglaman/phpstan-drupal, we see our "updated deps" test-runs fail on both 10.0.x and 10.1.x
https://www.drupal.org/node/3060/qa
Bump mglaman/phpstan-drupal to latest (including upping the version constraint in composer.json) AND refresh the baseline at the same time.
The accessCheck-related errors we're adding to the baseline here are being addressed in #3330981: Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated..."
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3336586-10.0.x-5.patch | 13.03 KB | spokje |
| #3 | 3336586-3.patch | 14.73 KB | spokje |
Comments
Comment #2
spokjeComment #3
spokjeComment #4
spokjeGrmbl, looks like our PHPStan baseline is out of sync between
10.0.xand10.1.x.INSTA-EDIT: Let's fix this in #3336590: Re-sync phpstan-baseline.neon between 10.0.x and 10.1.x
NOT-SO-INSTA-EDIT: Not much to do, since we've deprecated stuff in 10.1.x which we can't do in 10.0.x
Comment #5
spokjeComment #6
spokjeComment #7
spokjeRight...
Looks like a random JS test failure on 10.1.x in CKEditor5 happened twice, not putting any more test-cycles/effort in that.
Comment #8
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #9
longwaveWorks for me - let's add these to the baseline for now and then fix in the followup.
Comment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
nod_Comment #12
nod_Comment #15
catchCommitted/pushed to 10.1.x and 10.0.x respectively, thanks!