Olivero: use multi-class array for adding multiple classes templates

We are adding multiple classes by single array.
<div{{ content_attributes.addClass('content', 'container-inline') }}> We should add multiple classes by multi-class array.

To make it consistent we can use multi-class array.

Remaining tasks

Update mutli-class array in these files:
search-result.html.twig
node.html.twig
book-tree.html.twig
menu--primary-menu.html.twig
menu--secondary-menu.html.twig
menu-local-task.html.twig
menu.html.twig

User interface changes

None

CommentFileSizeAuthor
#2 3336323-2.patch823 bytesgauravvvv

Issue fork drupal-3336323

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3336323-2.patch823 bytes

Added a patch with multi array class. Please review

markconroy’s picture

markconroy commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, applies cleanly. Tested against D10-dev.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

Lets update the issue summary as to why there is interest in making this change. If it's for consistency, the scope should probably be expanded to other templates using multiple args. 

search-result.html.twig
node.html.twig
book-tree.html.twig
menu--primary-menu.html.twig
menu--secondary-menu.html.twig
menu-local-task.html.twig
menu.html.twig
gauravvvv’s picture

gauravvvv commented
Issue summary: View changes

Updated IS.

Gauravvv opened merge request !3471

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Addressed #4 and created MR. Please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: -Needs issue summary update +Needs Review Queue Initiative

MR 3471 seems to have some failures

May be the templates that are going through loops..

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.