Problem/Motivation

to make a smaller part of #3318306: Define the Package Manager API (package_manager.api.php is outdated) easily actionable

Steps to reproduce

Proposed resolution

  1. Make sure all classes events are documented , at least CollectIgnoredPathsEvent is not documented
  2. Ensure not deprecated remove methods are mentioned, at least \Drupal\package_manager\Event\ExcludedPathsTrait::excludePath should be removed
  3. Provide guidance on when event stopPropagation should be use

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3336243

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +sprint
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +core-mvp

tedbow opened merge request !670

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Created #3336247: Throw an exception if stopPropagation() called for `PreOperationStageEvent` and no error has been added because I realized you could easily mess up the validation if you didn't know what you were doing

kunal.sachdev’s picture

kunal.sachdev commented
Assigned: Unassigned » kunal.sachdev
kunal.sachdev’s picture

kunal.sachdev commented
Assigned: kunal.sachdev » Unassigned
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » kunal.sachdev
Status: Needs review » Needs work

4 remarks on the MR — but I'm so glad the API docs are getting improved! 😄👍

kunal.sachdev’s picture

kunal.sachdev commented
Assigned: kunal.sachdev » Unassigned
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

Getting there … but still a few remarks 😇

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » kunal.sachdev
kunal.sachdev’s picture

kunal.sachdev commented
Assigned: kunal.sachdev » Unassigned
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » kunal.sachdev
Status: Needs review » Needs work

Almost ready!

kunal.sachdev’s picture

kunal.sachdev commented
Assigned: kunal.sachdev » wim leers
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » kunal.sachdev
Status: Needs review » Needs work

99% done!

kunal.sachdev’s picture

kunal.sachdev commented
Assigned: kunal.sachdev » wim leers
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +blocker

Ready to land!

@tedbow: let's land this, so we can finally do #3318306: Define the Package Manager API (package_manager.api.php is outdated), which this blocks. 🤞

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Needs work

Sorry to kick this back, but there are a few things I'd like to see changed here for clarity's sake. (If you want, I can do the work - just assign it to me.)

kunal.sachdev’s picture

kunal.sachdev commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » phenaproxima
Status: Needs review » Reviewed & tested by the community
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Looks good to me!

Made a couple of small fixes-on-commit, will merge when tests pass.

  • phenaproxima committed 58237485 on 8.x-2.x authored by tedbow 
    Issue #3336243 by kunal.sachdev, tedbow, phenaproxima, Wim Leers: Update...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

This unblocked #3318306: #3318306-16: Define the Package Manager API (package_manager.api.php is outdated).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.