Drupal version 10.0.2

Expected Behavior

After enabled on certain forms, on domain change reload the page with correct settings.

Actual Behavior

No page reload, error logged.

Steps to reproduce

- fresh Drupal 10 install
- composer require 'drupal/domain:2.0.x-dev@dev'
- add domain records at admin/config/domain
- on admin/config/domain/config-ui i n"Enabled configuration forms" add (if not present) "/admin/appearance"
- go to /admin/appearance, change domain

AJAX throbber appears, but nothing happens.
Log shows an error:

Error: Call to undefined method Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() üzenet Drupal\domain_config_ui\Form\SwitchForm::switchCallback() függvényben (/var/www/html/phgy2.tatrai.hu/web/modules/contrib/domain/domain_config_ui/src/Form/SwitchForm.php 214. sorában)

CommentFileSizeAuthor
#3 d10-regression-3336172-3.patch867 bytescbeier

Issue fork domain-3336172

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eFeS created an issue. See original summary.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Title: SwitchForm.php » SwitchForm compatibility with Drupal 10
cbeier’s picture

cbeier commented
Status: Active » Needs review
StatusFileSize
new d10-regression-3336172-3.patch867 bytes

Patch attached to fix regression bug.

hongqing’s picture

hongqing commented

Thanks for the patch. It works with D10.0.9.

thejimbirch’s picture

thejimbirch commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and Switchform works.

I was able to change/add a domain's system.site.yml.

After the change was saved, I can now export the change to the config folder:

config/domain.config.site_name.system.site.yml

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Needs review

This needs to get rolled in to #3363211: Drupal 10.0.x Updates because it will not be committed without passing tests.

That said -- it looks like this solves the test problem I was having over there! Nice work!

Status: Needs review » Needs work

The last submitted patch, 3: d10-regression-3336172-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

shivam_tiwari made their first commit to this issue’s fork.

shivam_tiwari opened merge request !41

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs work » Needs review

  • agentrickard committed 43d1757d on 2.0.x 
    Issue #3336172 by cbeier: SwitchForm compatibility with Drupal 10. Fix...
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed

This has been committed as part of the linked issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.