Problem/Motivation

Using PHP 8.1.8 with both the Charts and Highcharts submodules enabled with a chart field, I encounter an AjaxError when attempting to upload a csv.

Deprecated: auto_detect_line_endings is deprecated in /var/www/docroot/html/modules/contrib/charts/src/Element/ChartDataCollectorTable.php on line 435

Steps to reproduce

  1. Install Charts on a site running PHP 8.1.x (confirmed on 8.1.8).
  2. Add a Chart field to an entity.
  3. Attempt to upload a csv and check the console for the error.

Proposed resolution

Remove `auto_detect_line_endings` per https://php.watch/versions/8.1/auto_detect_line_endings-ini-deprecated.

CommentFileSizeAuthor
#3 charts-remove-autodetectlineendings-3334641-2.patch681 bytesjacobsaw

Comments

jacobsaw created an issue. See original summary.

andileco’s picture

andileco commented

This is perfect timing ... I was just about to issue a new release. Will try to address this quickly.

jacobsaw’s picture

jacobsaw commented
StatusFileSize
new charts-remove-autodetectlineendings-3334641-2.patch681 bytes
jacobsaw’s picture

jacobsaw commented

Great! Added a patch, thanks for taking care of this.

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
Status: Active » Reviewed & tested by the community

+1 for removing. Checked and there is no side effect.

  • andileco committed 77288936 on 5.0.x 
    Issue #3334641 by jacobsaw, andileco, nikathone: PHP 8.1.8...
andileco’s picture

andileco commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.