Problem/Motivation

Currently you cannot set 0 on the maximum number of spaces for each registration, even through the descriptions states 0 means unlimited.

Steps to reproduce

Go to the registration settings and try to set 0 as the value on Spaces allowed.

Proposed resolution

Change base field definition to allow zero, and create a hook_update_n to change on existing installs.

Remaining tasks

Test and approve patch.

CommentFileSizeAuthor
#2 3334521-02-Registration_maximum_settings.patch1.76 KBdubs

Comments

Dubs created an issue. See original summary.

dubs’s picture

dubs commented
Status: Active » Needs review
StatusFileSize
new 3334521-02-Registration_maximum_settings.patch1.76 KB

Patch here :-)

john.oltman’s picture

john.oltman commented

Good catch and thanks for the patch. It looks like what we need, I'll double check it with a local test and should have this committed within the next few days. Depending on what else comes up should be in a release fairly soon after that.

dubs’s picture

dubs commented

Thanks John :-)

vitorbs’s picture

vitorbs commented

Hey, i'll review it too.

vitorbs’s picture

vitorbs commented
Assigned: Unassigned » vitorbs
vitorbs’s picture

vitorbs commented

I tested without the patch and it don't allow to put 0 in the label, says that needs be more than 1 and after the patch all worked successfully. Moving to RTBC.

vitorbs’s picture

vitorbs commented
Assigned: vitorbs » Unassigned
Status: Needs review » Reviewed & tested by the community

  • john.oltman committed c2ba47ac on 3.0.x authored by Dubs 
    Issue #3334521 by Dubs: Allow 0 (unlimited) to be set on Maximum number...
john.oltman’s picture

john.oltman commented

Committed. I had to change things a bit because the patch was against a previous version of the module and a hook update for 9001 already existed. Thanks for the catch and the test.

john.oltman’s picture

john.oltman commented
Status: Reviewed & tested by the community » Fixed
john.oltman’s picture

john.oltman commented
john.oltman’s picture

john.oltman commented

Released in beta3

vitorbs’s picture

vitorbs commented

I needed to delete the class to apply the patch, but it worked well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.