This module is still using old README.md template format in README.md file.

Follow the pattern in the README.md template.

CommentFileSizeAuthor
Layout_readme.PNG24.84 KBkavitha89

Issue fork layout_builder_base-3334376

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !2

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Create MR for README.md file update.
Please review.
Thanks.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs review » Needs work

A rebase is apparently needed to allow me to merge.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

Hi I will do it.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi I did the rebase, please revise.

lucienchalom’s picture

lucienchalom commented
Status: Needs review » Needs work

"Ordered lists use "1", for easier updates and to avoid errors"

So please fix in the Installation and Configuration sections?
thank you

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Please review. Thanks

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
aziza_a’s picture

aziza_a commented
Status: Needs review » Needs work

Shouldn't For site builders & For developers considered as heading rather than list??

shivam_tiwari made their first commit to this issue’s fork.

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs work » Needs review
lucienchalom’s picture

lucienchalom commented

I adressed #11, please review

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Reviewed & tested by the community » Needs review

kavitha@specbee.com: Please don't upload screenshots of your terminal showing a directory tree, it just adds noise to the issue.

Before an issue can be marked RTBC the changes need to be reviewed, this wasn't done.

Please read up on Issue Etiquette. Pay attention on #11 and #14 on the "Don't" list.

Your comment here is spam and has been deleted as such. I'm setting the status back to "Needs review".

nupur badola’s picture

nupur badola commented

Reviewed MR!2, the patch is not cleanly applied.

1. In Installation section, numbering should be done by 1,2,3.. but it is given as 1, 1, 1...

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs review » Fixed

Thank you, this is merged

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Fixed » Reviewed & tested by the community

Hi @phjou you forgot your credit to nitin_lama, lucienchalom, gisle and me please can you fix it?

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

I just checked the boxes, hopefully it shows up in your profile.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

Thank you I appreciate it!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.