[1.0.x] Meta Conversion API

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.


Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Hello jozzy_a

1. update README file according to https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template
2. Add help hook
3. It seems you have missed working on the coding standards. You can use PHPCS tool for checking and resolving issues.

 phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,json /var/www/html/meta_conversion_api-1.0.x-dev

FILE: /var/www/html/meta_conversion_api-1.0.x-dev/meta_conversion_api/src/Services/MetaClient.php
------------------------------------------------------------------------------------------------------------------
FOUND 29 ERRORS AND 6 WARNINGS AFFECTING 33 LINES
------------------------------------------------------------------------------------------------------------------
  69 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
  77 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
 120 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
 122 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 123 | ERROR   | [x] Return comment indentation must be 3 spaces, found 2 spaces
 125 | ERROR   | [ ] Type hint "array" missing for $user_data
 141 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 144 | ERROR   | [ ] Type hint "array" missing for $product_data
 155 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 158 | ERROR   | [ ] Parameter tags must be grouped together in a doc comment
 161 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 167 | ERROR   | [x] Short array syntax must be used to define arrays
 183 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 186 | ERROR   | [ ] Type hint "array" missing for $event_data
 186 | ERROR   | [ ] Expected type hint "array"; found "UserData" for $user_data
 186 | ERROR   | [ ] Expected type hint "array"; found "CustomData" for $custom_data
 198 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
 203 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 206 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
 208 | ERROR   | [ ] Protected method name "MetaClient::contains_required_data" is not in lowerCamel format
 209 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
 210 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
 225 | ERROR   | [ ] Protected method name "MetaClient::return_required_event_fields" is not in lowerCamel format
 227 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 228 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 229 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 230 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 231 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 232 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 233 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 234 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 235 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 236 | ERROR   | [x] Array closing indentation error, expected 4 spaces but found 6
 237 | ERROR   | [x] Expected 1 blank line after function; 0 found
 238 | ERROR   | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/meta_conversion_api-1.0.x-dev/meta_conversion_api/meta_conversion_api.routing.yml
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

Hello @jozzy_a,

File: meta_conversion_api.info.yml

core_version_requirement: ^9 | ^10

Use double pipe logical OR operator (||).

I am closing this application, since there haven't been replies in more than six months and the application has been created eight months ago or more.
Feel free to re-open it, once the project has been changed basing on what reported in the last review.