The module does not implement hook_help(), which should instead be implemented.

CommentFileSizeAuthor
#13 Config_track.png82.18 KBnupur badola
#8 help.png64.8 KBBushra Shaikh
#8 After Patch.png21.9 KBBushra Shaikh
#8 Before Patch.png20.79 KBBushra Shaikh
#7 added-hook-help-3332900-1.patch4.66 KBhimanshu_jhaloya
#4 Screenshot from 2023-01-18 20-12-18.png18.17 KBsharayurajput
#4 Screenshot from 2023-01-18 20-12-22.png67.7 KBsharayurajput

Issue fork config_track-3332900

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !2

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Hi i create MR for hook_help function in .module file.
Please review.
Thanks.

sharayurajput’s picture

sharayurajput commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2023-01-18 20-12-22.png67.7 KB
new Screenshot from 2023-01-18 20-12-18.png18.17 KB

MR is reviewed its working good as per requirement, attached screenshot
LGTM so moving to RTBC

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: hook_help function missing in .module file » hook_help() is not implemented
Status: Reviewed & tested by the community » Needs work

Without This module allows to log any configuration change in Drupal 9/10. that text makes less sense. Also, that hook should show something the users have not already read from the project page.

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: Unassigned » himanshu_jhaloya

I will work on that

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: himanshu_jhaloya » Unassigned
Status: Needs work » Needs review
StatusFileSize
new added-hook-help-3332900-1.patch4.66 KB

Created patch hook_help() is implemented. Please Review.

Bushra Shaikh’s picture

Bushra Shaikh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch.png20.79 KB
new After Patch.png21.9 KB
new help.png64.8 KB

I have verified and applied Patch#7 on Drupal 9.5.8 version.
patch is applied successfully, and help() is added cleanly. Added screenshots for reference.

Can be moved to RTBC+1.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: hook_help() is not implemented » Implement hook_help()
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Since the purpose of this task is adding a hook_help() implementation, the provided patch should focus on that. Fixing the code that does not follow the coding standards is off-topic for this issue.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Changes committed in the MR2. Please review. Thanks.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
nupur badola’s picture

nupur badola commented
StatusFileSize
new Config_track.png82.18 KB

module not installed.

hchonov made their first commit to this issue’s fork.

hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented
Status: Needs review » Fixed

This was just merged. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.