Closed (fixed)
Project:
Drupal core
Version:
10.1.x-dev
Component:
Claro theme
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Jan 2023 at 19:04 UTC
Updated:
28 Apr 2023 at 08:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gauravvvv commentedI have refactored the
views_ui.admin.pcss.cssfile. I have improved nesting in the file.Output: In the CSS file
views_ui.admin.cssthere is only small change that too re-positioning on some CSS. Please reviewComment #3
bspeare commentedComment #4
smustgrave commentedReviewed #2
Change for nesting looks good. Attaching views ui screenshot to show nothing appears broken.
Comment #6
smustgrave commentedRandom failure 1) Drupal\Tests\media\FunctionalJavascript\MediaSourceFileTest::testMediaFileSource
Comment #7
nod_Nesting looks good, can we use logical properties? seems like it would help here
Comment #8
gauravvvv commentedUpdated patch with logical properties. Attached interdiff for same.
Comment #9
gauravvvv commentedComment #10
santosh_verma commentedTested the Patch #8,
Nesting and logical properties both are looking good to me.
patch applied cleanly, tested the UI manually nothing look like broken.
RTBC +
Comment #11
nod_If you feel it's RTBC you can change the issues status to RTBC :)
Comment #13
nod_Committed d4ddbd2 and pushed to 10.1.x. Thanks!